Skip to content

OBPIH 6847 Created a reusable component for tags and catalogues and integrated it into the table for them#4995

Merged
awalkowiak merged 9 commits intodevelopfrom
OBPIH-6847
Jan 15, 2025
Merged

OBPIH 6847 Created a reusable component for tags and catalogues and integrated it into the table for them#4995
awalkowiak merged 9 commits intodevelopfrom
OBPIH-6847

Conversation

@SebastianLib
Copy link
Collaborator

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description:
Created a reusable, styled component for tags and catalogues that allows adding and customizing colors through props and integrated it into the tags and catalogues table


📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

@SebastianLib SebastianLib self-assigned this Jan 14, 2025
@github-actions github-actions bot added the domain: frontend Changes or discussions relating to the frontend UI label Jan 14, 2025
@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.65%. Comparing base (3005f87) to head (d9d14fe).
Report is 186 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##             develop   #4995   +/-   ##
=========================================
  Coverage       7.65%   7.65%           
  Complexity       832     832           
=========================================
  Files            609     609           
  Lines          42543   42543           
  Branches       10330   10330           
=========================================
  Hits            3257    3257           
  Misses         38809   38809           
  Partials         477     477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

--blue-300: #E9EDF4;
--blue-301: #D0DAED;
--blue-400: #7AA3F3;
--blue-401: #2192EE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it named like that in figma or it's your naming?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's my naming, I didn't know how to call it

@ewaterman
Copy link
Member

fyi, our tests run lint checks now (which is why they're failing). Checking the logs will show you what checks need to be fixed: https://github.com/openboxes/openboxes/actions/runs/12772736056/job/35602998863?pr=4995

@kchelstowski
Copy link
Collaborator

@SebastianLib there is an eslint error in the useAllProductsTab (fix imports)

@awalkowiak awalkowiak merged commit 01ad016 into develop Jan 15, 2025
8 checks passed
@awalkowiak awalkowiak deleted the OBPIH-6847 branch January 15, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants