Skip to content

OBPIH-6843 Add wrapper components for cycle count tabs#4978

Merged
awalkowiak merged 10 commits intodevelopfrom
OBPIH-6843
Dec 12, 2024
Merged

OBPIH-6843 Add wrapper components for cycle count tabs#4978
awalkowiak merged 10 commits intodevelopfrom
OBPIH-6843

Conversation

@kchelstowski
Copy link
Collaborator

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description:


📷 Screenshots & Recordings (optional)

Screenshot from 2024-12-11 15-06-15

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

@kchelstowski kchelstowski self-assigned this Dec 11, 2024
@github-actions github-actions bot added domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server domain: l10n Changes or discussions relating to localization & Internationalization labels Dec 11, 2024
@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 7.60%. Comparing base (708d3cf) to head (37874d3).
Report is 133 commits behind head on develop.

Files with missing lines Patch % Lines
...pih/warehouse/inventory/InventoryController.groovy 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #4978      +/-   ##
============================================
- Coverage       7.61%   7.60%   -0.01%     
+ Complexity       819     817       -2     
============================================
  Files            601     601              
  Lines          42335   42342       +7     
  Branches       10282   10284       +2     
============================================
- Hits            3223    3222       -1     
- Misses         38643   38652       +9     
+ Partials         469     468       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

font-weight: 600;
font-size: 16px;
line-height: 21px;
padding: 16px 8px 16px 8px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding: 16px 8px 16px 8px;
padding: 16px 8px;

😄

},
};

const parsedQueryParams = useQueryParams();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u can use just

Suggested change
const parsedQueryParams = useQueryParams();
const { tab } = useQueryParams();

@awalkowiak awalkowiak merged commit c805f61 into develop Dec 12, 2024
@awalkowiak awalkowiak deleted the OBPIH-6843 branch December 12, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI domain: l10n Changes or discussions relating to localization & Internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants