Skip to content

OBPIH-6190 Fix ESLint errors#4975

Merged
awalkowiak merged 3 commits intodevelopfrom
OBPIH-6190
Dec 12, 2024
Merged

OBPIH-6190 Fix ESLint errors#4975
awalkowiak merged 3 commits intodevelopfrom
OBPIH-6190

Conversation

@alannadolny
Copy link
Collaborator

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issues or Jira tickets:

  1. https://pihemr.atlassian.net/browse/OBPIH-6190
  2. https://pihemr.atlassian.net/browse/OBPIH-6191

Description:
Apart from those changes that were made automatically by running eslint fix, I did the following:

  1. Change errors on missing/wrong propTypes to warn - it's too complicated to fix this issue without context and knowledge of the exact data structure.
  2. Add a rule for handling associated controls - previously it needed both, nesting label + input and htmlFor, but only one is needed to make the HTML valid.
  3. Adding callbacks in this.setState
  4. Destructurize some variables if needed
  5. Fix circular dependency in three components in location configuration
  6. Add missing button types
  7. Add missing tabIndex
  8. Add missing accessibility properties
  9. Split too long lines with destructuring/additional variables/just breaking lines
  10. Remove unused propTypes
  11. Remove unused variables/imports
  12. Put functions that are not using this above the components
  13. Add jsx extension to the webpack

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

😄 😄 😄
image

@alannadolny alannadolny self-assigned this Dec 10, 2024
@github-actions github-actions bot added the domain: frontend Changes or discussions relating to the frontend UI label Dec 10, 2024
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.60%. Comparing base (8e9991c) to head (cfc0e8c).
Report is 126 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #4975      +/-   ##
============================================
- Coverage       7.68%   7.60%   -0.08%     
+ Complexity       828     817      -11     
============================================
  Files            601     601              
  Lines          42340   42340              
  Branches       10283   10283              
============================================
- Hits            3252    3222      -30     
- Misses         38614   38650      +36     
+ Partials         474     468       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@awalkowiak awalkowiak added the warn: do not merge Marks a pull request that is not yet ready to be merged label Dec 10, 2024
Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only cautious about the addition of prev => ... to this.setState, I know this is the way it should be done previously, but maybe there is a low risk that something was working due to lack of this prev arg, but I guess you checked that.

@awalkowiak awalkowiak removed the warn: do not merge Marks a pull request that is not yet ready to be merged label Dec 12, 2024
@awalkowiak awalkowiak merged commit d030806 into develop Dec 12, 2024
@awalkowiak awalkowiak deleted the OBPIH-6190 branch December 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants