Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4975 +/- ##
============================================
- Coverage 7.68% 7.60% -0.08%
+ Complexity 828 817 -11
============================================
Files 601 601
Lines 42340 42340
Branches 10283 10283
============================================
- Hits 3252 3222 -30
- Misses 38614 38650 +36
+ Partials 474 468 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kchelstowski
approved these changes
Dec 11, 2024
Collaborator
kchelstowski
left a comment
There was a problem hiding this comment.
I'm only cautious about the addition of prev => ... to this.setState, I know this is the way it should be done previously, but maybe there is a low risk that something was working due to lack of this prev arg, but I guess you checked that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issues or Jira tickets:
Description:
Apart from those changes that were made automatically by running eslint fix, I did the following:
htmlFor, but only one is needed to make the HTML valid.tabIndexthisabove the componentsjsxextension to the webpack📷 Screenshots & Recordings (optional)
😄 😄 😄
