OBPIH-6837 TD: Install second react table package#4972
Conversation
github-actions
bot
added
the
flag: config change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4972 +/- ##
============================================
- Coverage 7.65% 7.61% -0.05%
+ Complexity 825 817 -8
============================================
Files 601 601
Lines 42302 42302
Branches 10276 10276
============================================
- Hits 3239 3222 -17
- Misses 38593 38612 +19
+ Partials 470 468 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "@fortawesome/free-solid-svg-icons": "5.14.0", | ||
| "@fortawesome/react-fontawesome": "0.1.8", | ||
| "@hookform/resolvers": "3.3.4", | ||
| "@tanstack/react-table": "8.20.5", |
There was a problem hiding this comment.
is the plan to replace line 104 "react-table": "6.8.6", with this? Or do they work independently?
There was a problem hiding this comment.
Yeah, we want to replace it in the future, but it will probably be in the far-distant future. For now, we would like to have those libraries independently, the new library includes a new "hook" approach which will be needed in the cycle count implementation.
There was a problem hiding this comment.
sounds good. It's convenient that we can bring in both versions at the same time and then gradually switch over to using this new dependency.
My main concern is around having to support different behaviours across different tables, which may lead to inconsistencies in our UI, but I don't know the react table library well enough to know if that's a real concern or not.
Either way we'd probably need this upgrade eventually, so good that we're starting now
awalkowiak
added
warn: do not merge
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6837
Description: Because of the changes in packages in a newer version of react table I didn't have to use a forked library as a replacement for react-table version 6. I was able to add the newest version of the library and I tested it and it worked fine. The example that I tried to run in the app: https://tanstack.com/table/v8/docs/framework/react/examples/basic
📷 Screenshots & Recordings (optional)