I had to add this to make the job work. Without the @transactional it was hitting "no transaction is in progress" errors.

Maybe a better solution is to wrap each individual generateForAllUnassignedIdentifiers() call in their own transaction based on the underlying table that they're working on.

Or perhaps even better, simply put the @transactional on the XIdentiferService classes themselves and remove it from here so that if there's a failure in one, it doesn't affect the others.

@awalkowiak I see you had this PR relating to transactions in jobs so maybe you'll know better than me #4160

Possibly relevant since we are doing sessionRequired=false in all our jobs: https://grails.github.io/grails-quartz/guide/configuration.html

Hibernate Sessions and Jobs
Jobs are configured by default to have Hibernate Session bounded to thread each time job is executed. This is required if you are using Hibernate code which requires open session (such as lazy loading of collections) or working with domain objects with unique persistent constraint (it uses Hibernate Session behind the scene). If you want to override this behavior (rarely useful) you can use 'sessionRequired' property:

def sessionRequired = false

Thinking about it for a bit, I'd like to just put @transactional on all the XIdentiferService classes since that's what makes sense to me (they should probably be transactional anyways).

@ewaterman here you might find a bit more details about the issue with no transaction is in progress https://pihemr.atlassian.net/browse/OBGM-584 (this is the OG ticket under which I introduced the wrapping service calls with the withNewSession), this was basically the same issue you run into here: #4967 (comment), back then I remember @Transactional did not work for me. Does the @Transactional work now? Are the new identifiers persisted to the db correctly now?

from what I've gathered, the merge was required because the assign identifier job was wrapping all the generate id calls with the same Product.withNewSession, even though only one of them was actually saving to product. This meant that the entities might not have been in the session, and so we were forced to work with detached objects via merge. Now that we're leaving the transactions to the individual services themselves, which do the work to fetch the entities (and thus load them into the session) this is no longer required.