allow tests to run independently from code coverage#4960
Merged
Conversation
github-actions
bot
added
type: bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4960 +/- ##
=========================================
Coverage 7.62% 7.62%
Complexity 818 818
=========================================
Files 600 600
Lines 42275 42275
Branches 10276 10276
=========================================
Hits 3224 3224
Misses 38586 38586
Partials 465 465 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: N/A
Description: Removes the
finalizedBy jacocoTestReportblock in all test tasks that was generating jacoco reports.This was convenient for GitHub Actions since it allowed them to just run
./grailsw test-appto generate reports but it also prevented us from being able to do things likegrails test-app AuthApiSpec -integrationto refine what tests we want to run. jacocoTestReport hasdependsOn test, integrationTestso it'd end up running ALL the tests and ignoring the filters.This solution is actually better IMO in that it requires us to be more specific about when we want to run tests for the purpose of generating a report (
./gradlew jacocoTestReport)