Skip to content

OBPIH-6825 Fail order items import if recipient is an inactive user#4956

Merged
awalkowiak merged 1 commit intodevelopfrom
bug/OBPIH-6825-import-inactive-recipient
Nov 27, 2024
Merged

OBPIH-6825 Fail order items import if recipient is an inactive user#4956
awalkowiak merged 1 commit intodevelopfrom
bug/OBPIH-6825-import-inactive-recipient

Conversation

@ewaterman
Copy link
Member

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6825

Description: Fail importing order items if one of the recipients is an inactive user


📷 Screenshots & Recordings (optional)

Screencast.from.11-26-2024.09.42.37.AM.webm

@ewaterman ewaterman self-assigned this Nov 26, 2024
@github-actions github-actions bot added type: bug Addresses unintended behaviours of the app domain: backend Changes or discussions relating to the backend server labels Nov 26, 2024
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 7.62%. Comparing base (db9e9cc) to head (62de58a).
Report is 90 commits behind head on develop.

Files with missing lines Patch % Lines
...rvices/org/pih/warehouse/order/OrderService.groovy 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #4956      +/-   ##
============================================
- Coverage       7.62%   7.62%   -0.01%     
  Complexity       818     818              
============================================
  Files            600     600              
  Lines          42270   42274       +4     
  Branches       10275   10276       +1     
============================================
  Hits            3224    3224              
- Misses         38581   38585       +4     
  Partials         465     465              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awalkowiak awalkowiak merged commit 0d5b799 into develop Nov 27, 2024
@awalkowiak awalkowiak deleted the bug/OBPIH-6825-import-inactive-recipient branch November 27, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server type: bug Addresses unintended behaviours of the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants