OBPIH-6821 Try next sequence number if generating an order number fails#4948
Merged
awalkowiak merged 1 commit intodevelopfrom Nov 20, 2024
Merged
Conversation
github-actions
bot
added
type: bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4948 +/- ##
============================================
+ Coverage 7.61% 7.63% +0.01%
- Complexity 810 818 +8
============================================
Files 600 600
Lines 42243 42253 +10
Branches 10268 10272 +4
============================================
+ Hits 3216 3224 +8
Misses 38564 38564
- Partials 463 465 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@awalkowiak feel free to have someone take over this PR if we want to close it before the sprint ends since I'm out for the rest of the week. |
awalkowiak
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6821
Description: See ticket for details, but this PR fixes an issue where an organization's sequence number falls out of sync with the order numbers that we have generated for POs. Essentially the PR adds a retry mechanism where if the id we generate is not unique, check the next 10 sequence numbers if they're available.