Fix mkdocs build integration with readthedocs (fixes #4345)#4946
Merged
Fix mkdocs build integration with readthedocs (fixes #4345)#4946
Conversation
jmiranda
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4946 +/- ##
============================================
- Coverage 7.63% 7.62% -0.01%
+ Complexity 812 810 -2
============================================
Files 598 598
Lines 42194 42194
Branches 10261 10261
============================================
- Hits 3220 3216 -4
- Misses 38509 38515 +6
+ Partials 465 463 -2 ☔ View full report in Codecov by Sentry. |
Collaborator
|
|
Member
Author
|
Huzzah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
#4345
Description:
Readthedocs integration has been failing on all branches derived from develop for a long time. That leads to a failing build check for every PR that gets created.
Here's what the build on readthedocs looks like.
We fixed the issue months ago, but it's on a long-lived feature branch (OBPIH-6197) aimed at updating our docs for the 0.9.x release. And unfortunately, those change have not been pushed to develop yet.
So here we are.
And here's a recent build of the current branch on readthedocs, showing that the changes allows builds to pass successfully.