Skip to content

OBPIH-6733 Re-add release information to Sentry#4945

Merged
ewaterman merged 8 commits intodevelopfrom
maintenance/OBPIH-6733-sentry-performance-fix
Nov 15, 2024
Merged

OBPIH-6733 Re-add release information to Sentry#4945
ewaterman merged 8 commits intodevelopfrom
maintenance/OBPIH-6733-sentry-performance-fix

Conversation

@ewaterman
Copy link
Member

No description provided.

@github-actions github-actions bot added type: maintenance Code improvements, optimizations and refactors, dependency upgrades... domain: backend Changes or discussions relating to the backend server flag: config change Hilights a pull request that contains a change to the app config labels Nov 15, 2024
@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 7.62%. Comparing base (0bef6b9) to head (7d94b5e).
Report is 82 commits behind head on develop.

Files with missing lines Patch % Lines
...use/monitoring/SentryServletContextListener.groovy 76.19% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             develop   #4945      +/-   ##
============================================
+ Coverage       7.58%   7.62%   +0.03%     
- Complexity       806     810       +4     
============================================
  Files            597     598       +1     
  Lines          42173   42194      +21     
  Branches       10261   10261              
============================================
+ Hits            3200    3216      +16     
- Misses         38510   38515       +5     
  Partials         463     463              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewaterman
Copy link
Member Author

Had a minor breakthrough last night while randomly digging into Sentry.init flows. This is a marginally better approach to how we were setting the release before in that it also works when testing locally. I also added some more documentation around how Sentry.init works so that we're not confused in the future.

I'm going to merge in as is because I tested on obdev5 already

@ewaterman ewaterman self-assigned this Nov 15, 2024
@ewaterman ewaterman merged commit 69f0dd5 into develop Nov 15, 2024
@ewaterman ewaterman deleted the maintenance/OBPIH-6733-sentry-performance-fix branch November 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server flag: config change Hilights a pull request that contains a change to the app config type: maintenance Code improvements, optimizations and refactors, dependency upgrades...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant