Skip to content

OBPIH-6813 Fix product source not displaying on invoice tab of PO show page#4942

Merged
awalkowiak merged 1 commit intodevelopfrom
feature/OBPIH-6320-show-supplier-product-name-in-tooltips-invoice-tab
Nov 15, 2024
Merged

OBPIH-6813 Fix product source not displaying on invoice tab of PO show page#4942
awalkowiak merged 1 commit intodevelopfrom
feature/OBPIH-6320-show-supplier-product-name-in-tooltips-invoice-tab

Conversation

@drodzewicz
Copy link
Collaborator

@drodzewicz drodzewicz commented Nov 14, 2024 •
edited by atlassian bot
Loading

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: OBPIH-6320

Description:

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

@drodzewicz drodzewicz self-assigned this Nov 14, 2024
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI labels Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@dd39e17). Learn more about missing BASE report.
Report is 84 commits behind head on develop.

Additional details and impacted files 
@@            Coverage Diff            @@
##             develop   #4942   +/-   ##
=========================================
  Coverage           ?   7.58%           
  Complexity         ?     806           
=========================================
  Files              ?     597           
  Lines              ?   42173           
  Branches           ?   10261           
=========================================
  Hits               ?    3200           
  Misses             ?   38510           
  Partials           ?     463

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alannadolny
alannadolny reviewed Nov 14, 2024
View reviewed changes
grails-app/views/order/_orderInvoices.gsp Outdated
</g:if>
<g:else>
<format:displayName product="${invoiceItem?.product}" productSupplier="${invoiceItem?.orderItem?.productSupplier}" showTooltip="${true}" />
<format:displayName product="${invoiceItem?.product}" productSupplier="${invoiceItem?.shipmentItem?.orderItem?.productSupplier}" showTooltip="${true}" />
Copy link
Collaborator

@alannadolny alannadolny Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding a getter that would allow us to hide the whole call chain?

kchelstowski
kchelstowski reviewed Nov 14, 2024
View reviewed changes
grails-app/views/order/_orderInvoices.gsp Outdated
</g:if>
<g:else>
<format:displayName product="${invoiceItem?.product}" productSupplier="${invoiceItem?.orderItem?.productSupplier}" showTooltip="${true}" />
<format:displayName product="${invoiceItem?.product}" productSupplier="${invoiceItem?.shipmentItem?.orderItem?.productSupplier}" showTooltip="${true}" />
Copy link
Collaborator

@kchelstowski kchelstowski Nov 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember you showing that the previous version (the one you are getting rid of) was displaying correctly for the prepayment items (there was invoiceItem.orderItem present).
Won't this change make an opposite situation, so that this will work for the rest now, but will not work for the prepayment items, as they do not have a shipmentItem? 🤔

@drodzewicz drodzewicz force-pushed the feature/OBPIH-6320-show-supplier-product-name-in-tooltips-invoice-tab branch from 566a82f to e943a34 Compare November 15, 2024 08:47
@awalkowiak awalkowiak merged commit 0bef6b9 into develop Nov 15, 2024
@awalkowiak awalkowiak deleted the feature/OBPIH-6320-show-supplier-product-name-in-tooltips-invoice-tab branch November 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alannadolny alannadolny alannadolny left review comments

@kchelstowski kchelstowski kchelstowski left review comments

@awalkowiak awalkowiak awalkowiak approved these changes

Assignees

@drodzewicz drodzewicz

Labels

domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drodzewicz @awalkowiak @alannadolny @kchelstowski