OBPIH-6099 Fix issue with global recipient on outbound autosave#4932
Merged
awalkowiak merged 2 commits intodevelopfrom Nov 12, 2024
Conversation
github-actions
bot
added
type: feature
alannadolny
reviewed
Nov 8, 2024
Comment on lines
+1046
to
+1049
| if (editAll) { | ||
| return { ...item, rowSaveStatus: RowSaveStatus.PENDING }; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I can see that the line below has an additional condition when RowSaveStatus.PENDING is applied. Have you checked what will happen when editing the same row multiple times?
Collaborator
Author
There was a problem hiding this comment.
in that regard everything should work properly.
Addityionaly I have added the editAll condition to the following statement.
if (isEdited || editAll) {
this.debouncedSave();
return;
}this should ensure a safe items saveing step if there are pending save processes from previous actions.
alannadolny
approved these changes
Nov 12, 2024
awalkowiak
deleted the
feature/OBPIH-6099-fill-multiple-lines-in-shipment-with-the-same-recipient
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: /OBPIH-6099
Description: Issue was that on outbound workflow when autosave was enabled this globalr ecipient did not work propetly
Current autosave behacior only includes logic for individual edits on the row, since we are working with a "bulk" update I had to add some modifications like thi
editAllprop📷 Screenshots & Recordings (optional)