OBPIH-6321 Show supplier product name in po documents#4930
Merged
awalkowiak merged 1 commit intodevelopfrom Nov 7, 2024
Merged
OBPIH-6321 Show supplier product name in po documents#4930awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
ewaterman
github-actions
bot
added
the
domain: backend
alannadolny
reviewed
Nov 7, 2024
| totalPrice: v?.sum { it.totalPrice() }, | ||
| budgetCode: v?.budgetCode?.first()?.code ?: "", | ||
| expectedShippingDate: v?.estimatedReadyDate?.first() ? v?.estimatedReadyDate?.first()?.format(Constants.EUROPEAN_DATE_FORMAT) : "" | ||
| expectedShippingDate: v?.estimatedReadyDate?.first() ? v?.estimatedReadyDate?.first()?.format(Constants.EUROPEAN_DATE_FORMAT) : "", |
Collaborator
There was a problem hiding this comment.
have you tried what will happen if estimatedReadyDate is null? I remember that .first() in Groovy is broken and even if there is a null safe operator it can throw an error.
Collaborator
Author
There was a problem hiding this comment.
I have not changed anything here (except adding a comma), so I assume this must have been tested and is working properly.
alannadolny
approved these changes
Nov 7, 2024
Member
|
wow those methods in DocumentService are huge |
ewaterman
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
📷 Screenshots & Recordings (optional)