OBPIH-6320 show supplier product name in tooltips#4929
Merged
awalkowiak merged 7 commits intodevelopfrom Nov 8, 2024
Merged
Conversation
github-actions
bot
added
type: feature
alannadolny
reviewed
Nov 7, 2024
| </td> | ||
| </g:if> | ||
| <td style="color: ${orderItem?.product?.color}"> | ||
| <td style="color: ${orderItem?.product?.color}" title="hello"> |
Comment on lines
89
to
91
| const productSupplierName = orderItem?.productSupplierName | ||
| ? `(source: ${orderItem?.productSupplierName})` | ||
| : null; |
Collaborator
There was a problem hiding this comment.
Maybe it can be moved to a separate function for getting productSupplierName? I can see that it is used more than once
alannadolny
approved these changes
Nov 8, 2024
awalkowiak
approved these changes
Nov 8, 2024
awalkowiak
deleted the
feature/OBPIH-6320-show-supplier-product-name-in-tooltips
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6320
Description:
📷 Screenshots & Recordings (optional)