OBPIH-6698 Include label and defaultMessage in base field componnt when props are passed as dynamic attributes#4920
Merged
awalkowiak merged 1 commit intodevelopfrom Oct 30, 2024
Conversation
…en props are passed as dynamic attributes
github-actions
bot
added
type: feature
kchelstowski
approved these changes
Oct 30, 2024
awalkowiak
approved these changes
Oct 30, 2024
awalkowiak
deleted the
feature/OBPIH-6698-fix-passing-label-props-in-render-form0-util
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6698
Description:
After some recent changes to the receiving workflow it appears that props
labelanddefaultMessagewere not properly passed to the BaseField component when passing them through dyanmicAttributes which broke the test because screen reader was not able to find the appropriate textfield when looking for Receving now field by label📷 Screenshots & Recordings (optional)