Skip to content

OBPIH-5182 (with fix) IdentifierService overhaul#4915

Merged
awalkowiak merged 9 commits intodevelopfrom
maintenance/OBPIH-5182-custom-id-refactor
Oct 25, 2024
Merged

OBPIH-5182 (with fix) IdentifierService overhaul#4915
awalkowiak merged 9 commits intodevelopfrom
maintenance/OBPIH-5182-custom-id-refactor

Conversation

@ewaterman
Copy link
Member

@ewaterman ewaterman commented Oct 24, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-5182

Description: Trying again. Same change as #4885 but with the following fixes:

  1. A simple fix on stock transfer and stock movements id generation (was missing a param. Truly don't know how I missed that)
  2. Support the old way of defining sequenceNumber in template for POs (didn't catch in my testing because PIH envs use a custom config override)
  3. Generating product ids for non-default product types that have a code now use that code (didn't catch it in my testing because we don't actually have any product types with a code set)

@ewaterman ewaterman self-assigned this Oct 24, 2024
@github-actions github-actions bot added type: maintenance Code improvements, optimizations and refactors, dependency upgrades... domain: backend Changes or discussions relating to the backend server flag: config change Hilights a pull request that contains a change to the app config labels Oct 24, 2024
@ewaterman ewaterman requested a review from awalkowiak October 24, 2024 19:51
@awalkowiak awalkowiak merged commit 893cd33 into develop Oct 25, 2024
@awalkowiak awalkowiak deleted the maintenance/OBPIH-5182-custom-id-refactor branch October 25, 2024 11:34
jwalbers pushed a commit to jwalbers/openboxes that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server flag: config change Hilights a pull request that contains a change to the app config type: maintenance Code improvements, optimizations and refactors, dependency upgrades...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants