OBPIH-6781 prevent refreshing and deleting prepayment invoices that already have final invoices associated#4903
Merged
awalkowiak merged 3 commits intorelease/0.9.2-hotfix1from Oct 22, 2024
Conversation
…d add validation when trying to rollback when final invoice exists
…ile final invoice exists
github-actions
bot
added
type: feature
drodzewicz
changed the title
awalkowiak
requested changes
Oct 22, 2024
| } else { | ||
| invoiceInstance.datePosted = null | ||
| if (params.refreshInvoice && invoiceInstance.isPrepaymentInvoice) { | ||
| invoiceService.refreshInvoiceItems(invoiceInstance) |
Collaborator
There was a problem hiding this comment.
I think this method is only used here, so it could be removed as well.
awalkowiak
approved these changes
Oct 22, 2024
awalkowiak
deleted the
feature/OBPIH-6781-prevent-refreshing-and-deleting-prepayment-invoices-that-already-have-final-invoices-associated
branch
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
…lready have final invoices associated (openboxes#4903)
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
…lready have final invoices associated (openboxes#4903)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6781
Description:
📷 Screenshots & Recordings (optional)
When trying to rollback prepayment invoice while regular invoice exists
When trying to delete prepayment invoice while regular invoice exists