OBPIH-6226 Add PO UoM in the PO receipt workflow#4899
Merged
awalkowiak merged 5 commits intodevelopfrom Oct 18, 2024
Merged
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: backend
alannadolny
force-pushed
the
OBPIH-6226-2
branch
from
b317c71 to
bdde2bd
Compare
awalkowiak
reviewed
Oct 17, 2024
|
|
||
| String getDisplayUnitOfMeasure() { | ||
| return "${shipmentItem?.quantityPerUom?.toInteger()} ${shipmentItem?.unitOfMeasure}" | ||
| return "${shipmentItem?.orderItem?.quantity} ${shipmentItem?.unitOfMeasure}" |
Collaborator
There was a problem hiding this comment.
@alannadolny Should this show how much was shipped or how much was ordered?
Collaborator
Author
There was a problem hiding this comment.
ordered, shipped is already multiplied (qty * qty per uom)
when I order 5 quantities of something in a pack of 3, I want to display:
5 PACK/3, and then the quantity shipped is displayed in "Shipped (each)" column as 15
Collaborator
There was a problem hiding this comment.
But what if it is partial shipment of part of the ordered quantity?
github-actions
bot
added
the
domain: frontend
github-actions
bot
added
the
domain: l10n
awalkowiak
approved these changes
Oct 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.