OBPIH-6692 handle negative invoiced amount numbers and invoiced amount not equal to total adjustment amount#4893
Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from Oct 14, 2024
Conversation
…t not equal to total adjustment amount
github-actions
bot
added
type: feature
awalkowiak
reviewed
Oct 11, 2024
| OR invoice.invoice_type_id IS NULL | ||
| OR invoice.date_posted IS NULL | ||
| OR (invoice.date_posted IS NOT NULL AND adjustment_invoice_amount.total_invoiced_amount < order_adjustment_details.total_adjustment) | ||
| OR (invoice.date_posted IS NOT NULL AND ABS(adjustment_invoice_amount.total_invoiced_amount) != order_adjustment_details.total_adjustment) |
Collaborator
There was a problem hiding this comment.
@drodzewicz Shouldn't this part order_adjustment_details.total_adjustment be abs as well?
Collaborator
Author
There was a problem hiding this comment.
it is already ABS'ed in the order_adjustment_details view
awalkowiak
approved these changes
Oct 14, 2024
awalkowiak
deleted the
feature/OBPIH-6692-show-adjustments-with-invoice-amount-not-fully-invoiced-on-outstanding-order-report
branch
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
…t not equal to total adjustment amount (openboxes#4893)
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
…t not equal to total adjustment amount (openboxes#4893)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6692
Description:
There were two points needed fixing
📷 Screenshots & Recordings (optional)