OBPIH-6691 Add partially invoiced order summary status for order adjustments#4884
Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from Oct 9, 2024
Merged
OBPIH-6691 Add partially invoiced order summary status for order adjustments#4884awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
flag: schema change
awalkowiak
approved these changes
Oct 9, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6691
Description:
This reopen was due to the following behavior:
- Create PO, add an item, and adjustment with a percentage value for that item
- Generate prepayment invoice
- Generate final invoice for adjustment
- Edit unit price/qty of the item to lower value
- Generate final invoice pending value difference for adjustment
- Ship item
- Generate invoice for item
See that status remains Partially Invoiced.
This issue was caused by the fact, that if we are editing an order item that is bound with order adjustment we have to invoice the value difference, which is a negative value, but the value of the adjustment is positive. After summing the absolute amount values for the order we had, for example:
invoicing the "difference" in values is the only case when we are able to invoice the same order adjustment with negative and positive values because we have validation for that in every editting.