OBPIH-6631 Add a bit more comments in product merge service#4883
Merged
awalkowiak merged 1 commit intodevelopfrom Oct 9, 2024
Merged
OBPIH-6631 Add a bit more comments in product merge service#4883awalkowiak merged 1 commit intodevelopfrom
awalkowiak merged 1 commit intodevelopfrom
Conversation
awalkowiak
requested review from
alannadolny,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: backend
alannadolny
reviewed
Oct 8, 2024
| // Swap assemblyProduct to primary | ||
| obsoletedComponent.assemblyProduct = primary | ||
| // Note: needs flush because of "User.locationRoles not processed by flush" | ||
| // (this was an issue on grails 1.3.9, might not be a case anymore) |
Collaborator
There was a problem hiding this comment.
Maybe it will be worth creating a ticket for checking that and removing if this is unnecessary?
Collaborator
Author
There was a problem hiding this comment.
alannadolny
approved these changes
Oct 8, 2024
kchelstowski
approved these changes
Oct 8, 2024
| // Swap assemblyProduct to primary | ||
| obsoletedComponent.assemblyProduct = primary | ||
| // Note: needs flush because of "User.locationRoles not processed by flush" | ||
| // (this was an issue on grails 1.3.9, might not be a case anymore) |
Collaborator
There was a problem hiding this comment.
nitpicky and not related/not important now, but I'm actually curious why User.locationRoles would even have an impact on those saves + if we were to remove the flush, we could get rid of those explicit saves at all, as we update an existing entity and all of the changes are tracked by Hibernate
Collaborator
Author
There was a problem hiding this comment.
Feels like, the "User.locationRoles not processed by flush" was often issue in the past, but what was the core of it I don't know/remember.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-6631
Description:
A bit of comments in the product merge service