OBPIH-6692 modify order adjustments query on amount outstanding on orders report#4879
Merged
awalkowiak merged 3 commits intorelease/0.9.2-hotfix1from Oct 8, 2024
Conversation
…ially invoiced adjustments
drodzewicz
requested review from
alannadolny,
awalkowiak,
ewaterman and
kchelstowski
drodzewicz
changed the title
github-actions
bot
added
type: feature
awalkowiak
requested changes
Oct 7, 2024
| ) AS order_total ON order_adjustment.order_id = order_total.order_id | ||
| WHERE order_adjustment.canceled IS NOT TRUE | ||
| GROUP BY order_adjustment_id | ||
| ) AS total_adjustments ON total_adjustments.order_adjustment_id = order_adjustment.id |
Collaborator
There was a problem hiding this comment.
I think these changes should not be here.
Collaborator
Author
There was a problem hiding this comment.
yeah, probably, but I am not sure where are they supposed to be then.
Most of the views are built around the whole order, I need to put this total_adjustment amount on an individual adjustment.
Where do you suggest the best place for that be?
…unt outstanding report
awalkowiak
approved these changes
Oct 8, 2024
awalkowiak
deleted the
feature/OBPIH-6692-modify-order-adjustments-query-on-amount-outstanding-on-orders-report
branch
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6692
Description:
The goal was to check for the total adjustment amount and invoiced amount and add it as an additional condition to include these adjustments in amount outstanding report.
📷 Screenshots & Recordings (optional)