OBPIH-6724 Fix invoice item count on invoice list page#4859
Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from Sep 25, 2024
Conversation
ignore inverse items
github-actions
bot
added
type: feature
alannadolny
reviewed
Sep 24, 2024
| LEFT JOIN reference_number ON invoice_reference_number.reference_number_id = reference_number.id AND reference_number.reference_number_type_id = 'VENDOR_INVOICE_NUMBER' | ||
| LEFT JOIN party ON invoice.party_id = party.id | ||
| LEFT JOIN invoice_type ON invoice.invoice_type_id = invoice_type.id | ||
| WHERE invoice_item.inverse IS FALSE |
Collaborator
There was a problem hiding this comment.
I am not sure how it works now because we have the migration for the old data, but maybe it would be better to check if this field is null, just to be safe in case when something didn't go well with the migration?
awalkowiak
approved these changes
Sep 25, 2024
awalkowiak
deleted the
feature/OBPIH-6724-incorrect-number-of-items-count-on-invoices-list-for-purchase-invoices-for-prepaid-p-os
branch
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore inverse items
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6724
Description:
Ignore the inverse items when counting invoice items on invoice list page
📷 Screenshots & Recordings (optional)