OBPIH-6761 Sorting issue on invoice confirm page for long list of items (fix after QA)#4853
Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from Sep 20, 2024
Merged
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: frontend
awalkowiak
approved these changes
Sep 20, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
…ms (fix after QA) (openboxes#4853)
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
…ms (fix after QA) (openboxes#4853)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6716
Description:
The issue was caused by the behavior of fetching implemented in react-virtualize - the stop index passed by the react table when deleting an item is 10 (our default page size). So when we deleted an item in the middle of the table, the react-virtualize started fetching the items again, and the sent requests were: (startIndex: 0, stopIndex: 10), and the next one is, for example (startIndex: 16, stopIndex: 40). So because of that we are missing 6 items, and then when scrolling through the table we are fetching those missing items, and they are placed at the end of the table when we are on their indexes. Our implementation of the react-virtualize causes it so it's better not to touch the code here to avoid risky regressions in our tables. As a fix, I decided to fetch the table full table content after deletion, because when we are deleting items, at for example index 40 out of 70, we need all of the 40 items + current page size. + This fix removes a different behavior of blinking items because of building the rows once again.