OBPIH-6726 Bugfix to allow pre-migration prepayment invoices to be edited#4852
Merged
ewaterman merged 3 commits intorelease/0.9.2-hotfix1from Sep 23, 2024
Conversation
ewaterman
requested review from
alannadolny,
awalkowiak,
drodzewicz and
kchelstowski
github-actions
bot
added
type: bug
awalkowiak
reviewed
Sep 20, 2024
Collaborator
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
On a first sight it looks good to me, but I'd like to test it locally with my recent changes as well, before merging
…ms related invoice items
awalkowiak
approved these changes
Sep 23, 2024
ewaterman
deleted the
bugfix/OBPIH-6726-edit-migrated-prepayment-invoices
branch
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
…ited (openboxes#4852) Co-authored-by: Walkowiak <[email protected]>
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
…ited (openboxes#4852) Co-authored-by: Walkowiak <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6726
Description: See ticket for the full breakdown. This fix is to ensure that when migrating existing invoices we're properly creating an inverse invoice item for each matching shipment item in a regular invoice. Previously we were only checking the prepayment invoice item, which is based on order item and so had no shipment association. This worked fine for cancelled items and adjustments, but for orders with shipments, the invoice needs to be built off of the regular invoice item (which itself is built from shipment items).
A diagram to help me understand the complex relationships going on here: