OBPIH-6716 Sorting issue on invoice confirm page for long list of items #4845
Merged
awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from Sep 18, 2024
Merged
OBPIH-6716 Sorting issue on invoice confirm page for long list of items #4845awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from
awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: frontend
kchelstowski
approved these changes
Sep 18, 2024
drodzewicz
approved these changes
Sep 18, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6716
Description:
The first fix was to use a map as it is mentioned in the docs:
The second fix is to allow react-virtualize to fetch the number of items that the table needs. Previously we were fetching only 10 items each time. So in case of quick scrolling, we missed some items.