OBPIH-6725 Fix validation discrepancy when changing a location during…#4844
Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from Sep 18, 2024
Merged
OBPIH-6725 Fix validation discrepancy when changing a location during…#4844awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
Conversation
… outbound import process
alannadolny
approved these changes
Sep 17, 2024
awalkowiak
approved these changes
Sep 17, 2024
drodzewicz
approved these changes
Sep 18, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… outbound import process
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
The problem was that when the location changed, in the
useEffectwe were only setting the newly chosen location as origin in thesetValueofreact-hook-form, but the cached data still contained the old location, hence we had a situation that we sent the old origin for validation, but would send a new one for saving.To fix the issue I just make sure each time the cached data is supposed to be sent, we send it with the current location.
📷 Screenshots & Recordings (optional)