Skip to content

OBPIH-6725 Fix validation discrepancy when changing a location during…#4844

Merged
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
OBPIH-6725
Sep 18, 2024
Merged

OBPIH-6725 Fix validation discrepancy when changing a location during…#4844
awalkowiak merged 1 commit intorelease/0.9.2-hotfix1from
OBPIH-6725

Conversation

@kchelstowski
Copy link
Collaborator

… outbound import process

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description:
The problem was that when the location changed, in the useEffect we were only setting the newly chosen location as origin in the setValue of react-hook-form, but the cached data still contained the old location, hence we had a situation that we sent the old origin for validation, but would send a new one for saving.
To fix the issue I just make sure each time the cached data is supposed to be sent, we send it with the current location.


📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

@kchelstowski kchelstowski self-assigned this Sep 17, 2024
@github-actions github-actions bot added the domain: frontend Changes or discussions relating to the frontend UI label Sep 17, 2024
@kchelstowski kchelstowski added warn: do not merge Marks a pull request that is not yet ready to be merged and removed warn: do not merge Marks a pull request that is not yet ready to be merged labels Sep 17, 2024
@awalkowiak awalkowiak merged commit 417edcf into release/0.9.2-hotfix1 Sep 18, 2024
@awalkowiak awalkowiak deleted the OBPIH-6725 branch September 18, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants