[OBPIH-6612] BUGFIX: set amount field when migrating existing final prepayment invoice items#4838
Merged
ewaterman merged 4 commits intorelease/0.9.2-hotfix1from Sep 12, 2024
Merged
Conversation
github-actions
bot
added
domain: backend
ewaterman
requested review from
alannadolny,
awalkowiak,
drodzewicz and
kchelstowski
kchelstowski
approved these changes
Sep 12, 2024
| } | ||
|
|
||
| prepaymentInvoiceMigrationService.generateInverseInvoiceItems(prepaymentInvoice, regularInvoice) | ||
| prepaymentInvoiceMigrationService.migrateFinalInvoice(prepaymentInvoice, regularInvoice) |
Collaborator
There was a problem hiding this comment.
I don't know how it will act in this case, but usually, we don't edit the existing migrations, since they could be already run on an instance, so in order to make sure this would work, you should probably delete the record of this migration on staging.
Collaborator
There was a problem hiding this comment.
Yeah, after merging I will reload staging's db. So I think this should not be an issue there.
alannadolny
approved these changes
Sep 12, 2024
awalkowiak
approved these changes
Sep 12, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
…repayment invoice items (openboxes#4838)
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
…repayment invoice items (openboxes#4838)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6612
Description: When migrating existing prepayment invoices, we need to also set the amount field for any existing final invoice items so that the "Total Price" column displays correctly when viewing the final invoice.