OBPIH-6675 Errors cached despite leaving outbound import workflow#4835
Merged
awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from Sep 12, 2024
Merged
OBPIH-6675 Errors cached despite leaving outbound import workflow#4835awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from
awalkowiak merged 2 commits intorelease/0.9.2-hotfix1from
Conversation
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
ewaterman
github-actions
bot
added
the
domain: frontend
ewaterman
approved these changes
Sep 10, 2024
drodzewicz
requested changes
Sep 11, 2024
Collaborator
There was a problem hiding this comment.
Good job!
Could you also remove the
...
else {
clearCachedData();
}from the useMemo for default values
First I think it is unnecessary to call it there anymore since now we are calling clearCahcedData in the useEffect hook (what you have impement)
And also it is probably wrong to call any methods with side-effect in a useMemo hook (my bad 🙈 )
drodzewicz
approved these changes
Sep 11, 2024
awalkowiak
approved these changes
Sep 12, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 29, 2024
jwalbers
pushed a commit
to jwalbers/openboxes
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6675?atlOrigin=eyJpIjoiZDA1OTBlNmVjN2U5NDk5ZmFhOGY1YWE3MmFkMmYwOTMiLCJwIjoiaiJ9
Description:
The problem here was that the cached data was cleared, but two
useEffectswere affecting themselves, hence before they were cleared, the cached data was sent for validation, as it was not empty yet.To fix that, we want to load the cached data only if we are on the confirm step.