OBPIH-6668 Responsiveness in very long shipments with split line appears and disappears#4831
OBPIH-6668 Responsiveness in very long shipments with split line appears and disappears#4831awalkowiak merged 4 commits intodevelopfrom
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
the
domain: frontend
kchelstowski
left a comment
kchelstowski
left a comment
There was a problem hiding this comment.
as a side note: in some places it's a bit difficult to spot, what is actually changed and what are just the lint fixes, so I would not call the fix eslint on a whole file, or at least indicate in a PR what lines are the "real" changes" and which could be skipped.
|
|
||
| this.loadMoreRows(append)({ | ||
| startIndex: startIndex + this.props.pageSize, | ||
| fetchedLineItems: fetchedLineItems + lineItemsData.length, |
There was a problem hiding this comment.
at first thought I would think that fetchedLineItems actually store the items, not the size of the items, so how about renaming it to fetchedItemsSize/fetchedLineItemsSize/fetchedLineItemsCount?
There was a problem hiding this comment.
changed and what are just the lint fixes, so I would not call the fix eslint on a whole file
btw, I think we should run the linter for the entire project some time ago.
There was a problem hiding this comment.
fetchedLineItems: fetchedLineItems + lineItemsData.length,
I noticed that it's not used anymore, so I am deleting it 😄
4 participants
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6668
Description:
The issue with disappearing new lines was caused by managing the state in the component and in the form state at the same time, so when we were fetching new lines, we overrode the already created new lines.