OBPIH-6667 Cleanup full outbound import#4829
Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom Sep 6, 2024
Merged
OBPIH-6667 Cleanup full outbound import#4829awalkowiak merged 1 commit intofeature/outbound-importfrom
awalkowiak merged 1 commit intofeature/outbound-importfrom
Conversation
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
ewaterman
github-actions
bot
added
domain: frontend
alannadolny
approved these changes
Sep 6, 2024
awalkowiak
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses most of the changes requested in the WIP outbound import PR (feature branch -> develop).
I focused on suggestions, that do not touch the functionality, because it would be to risky to address them now.
When there is time for it, we'll decide together which parts could be treated as tech debt and which parts are "must-have" to refactor, as I still feel like we have some uncovered decision over there.