[OBPIH-6516] [Fix after QA] Add origin location to Product Availability search condition#4826
Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom Sep 4, 2024
Conversation
kchelstowski
approved these changes
Sep 4, 2024
awalkowiak
approved these changes
Sep 4, 2024
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
…ty search condition (#4826)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
The query was missing an additional condition which was the origin location for Product Availability.
Without it, it would search for all PA in all available locations.
Additionally retuned lotNumber from inventory Item object because there is a difference in displaying these values.
InventoryItem object for default lot number has lotNumber as null while the property on ProductAvailability has a string value "DEFAULT".
QA requested to unify this display as in other similar places and not show any text for default lots
📷 Screenshots & Recordings (optional)
📈 Test Plan
Description of test plan (if applicable):
✅ Quality Checks
[OBS-123]for Jira,[#0000]for GitHub, or[OBS-123, OBPIH-123]if there are multiple), or with[N/A]if not applicable