Skip to content

[OBPIH-6516] [Fix after QA] Add origin location to Product Availability search condition#4826

Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom
bugfix/OBPIH-6516-inferring-lot-in-packing-list-import-for-full-outbound
Sep 4, 2024
Merged

[OBPIH-6516] [Fix after QA] Add origin location to Product Availability search condition#4826
awalkowiak merged 1 commit intofeature/outbound-importfrom
bugfix/OBPIH-6516-inferring-lot-in-packing-list-import-for-full-outbound

Conversation

@drodzewicz
Copy link
Collaborator

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:

Description:
The query was missing an additional condition which was the origin location for Product Availability.
Without it, it would search for all PA in all available locations.

Additionally retuned lotNumber from inventory Item object because there is a difference in displaying these values.
InventoryItem object for default lot number has lotNumber as null while the property on ProductAvailability has a string value "DEFAULT".
QA requested to unify this display as in other similar places and not show any text for default lots


📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@drodzewicz drodzewicz self-assigned this Sep 4, 2024
@github-actions github-actions bot added type: bug Addresses unintended behaviours of the app domain: backend Changes or discussions relating to the backend server labels Sep 4, 2024
@awalkowiak awalkowiak merged commit 26c30cf into feature/outbound-import Sep 4, 2024
@awalkowiak awalkowiak deleted the bugfix/OBPIH-6516-inferring-lot-in-packing-list-import-for-full-outbound branch September 4, 2024 14:08
awalkowiak pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server type: bug Addresses unintended behaviours of the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants