OBPIH-6660 Fix roles removal after submitting full outbound import ac…#4821
Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom Sep 3, 2024
Merged
OBPIH-6660 Fix roles removal after submitting full outbound import ac…#4821awalkowiak merged 1 commit intofeature/outbound-importfrom
awalkowiak merged 1 commit intofeature/outbound-importfrom
Conversation
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz and
ewaterman
github-actions
bot
added
the
domain: frontend
alannadolny
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After latest changes to saving progress in full outbound import, there was one regression connected to the
handleConfirmSubmitForm- the form values that are handled automaically were first parsed by the Zod schema, whereas thegetValues()used in this method, were returning whole objects, in this case - instead of returning onlyid,name,labelfor a user and passing it to the backend, we were sending whole user object including roles, that were not parsed correctly.