[OBPIH-6634] improve validation on not existing bin locations in full outbound import#4817
Merged
kchelstowski merged 4 commits intofeature/outbound-importfrom Sep 3, 2024
Conversation
drodzewicz
requested review from
alannadolny,
awalkowiak,
ewaterman and
kchelstowski
github-actions
bot
added
type: feature
kchelstowski
reviewed
Sep 3, 2024
| binLocation(nullable: true) | ||
| binLocation(nullable: true, validator: { Location binLocation, ImportPackingListItem item -> | ||
| if (!item.binLocationFound) { | ||
| return ['binLocationNotFound', binLocation.name] |
Collaborator
There was a problem hiding this comment.
if so, this should also be included in the quantityPicked validation
| // We want to indicate if a recipient was not found, but the search term was given | ||
| obj.recipientFound = false | ||
| // returns a dummy person object to add more context in a response of what person was not found | ||
| return new Person(firstName: source['recipient'], lastName: "") |
Collaborator
There was a problem hiding this comment.
I can't see it being included in the recipient validator in the same way, as you included it in the bin location validator.
alannadolny
approved these changes
Sep 3, 2024
ewaterman
approved these changes
Sep 3, 2024
kchelstowski
approved these changes
Sep 3, 2024
kchelstowski
deleted the
feature/OBPIH-6634-improve-validation-on-not-existing-bin-locations-in-full-outbound-import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6634
Description:
Improve response on validation of not existing bin locations and not existing recipeints.
We want to return a value that the user has submitted and highlight it that it is not valid (was not found) instead of not returning anything.
I decided to just bind the bin location name to Location object and return it (same with recipient).
📷 Screenshots & Recordings (optional)
📈 Test Plan
Description of test plan (if applicable):
✅ Quality Checks
[OBS-123]for Jira,[#0000]for GitHub, or[OBS-123, OBPIH-123]if there are multiple), or with[N/A]if not applicable