OBPIH-6513+OBPIH-6514 Indicator for items requiring attention + include file row…#4813
Merged
awalkowiak merged 2 commits intofeature/outbound-importfrom Aug 30, 2024
Merged
OBPIH-6513+OBPIH-6514 Indicator for items requiring attention + include file row…#4813awalkowiak merged 2 commits intofeature/outbound-importfrom
awalkowiak merged 2 commits intofeature/outbound-importfrom
Conversation
kchelstowski
force-pushed
the
OBPIH-6513
branch
from
91bab4b to
4431bd8
Compare
github-actions
bot
added
domain: frontend
kchelstowski
changed the title
alannadolny
reviewed
Aug 30, 2024
Comment on lines
4
to
10
| const [isFiltered, setIsFiltered] = useState(false); | ||
|
|
||
| return { | ||
| setIsFiltered, | ||
| isFiltered, | ||
| }; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Maybe it's worth moving to this hook more logic related to filtering? Generally speaking, having a hook with just one setState is not worth creating this hook 😄
I think you can move to this hook actions like:
setIsFiltered((prev) => !prev);
and call it toggleFiltering
or things like that:
isFiltered
? (itemsWithErrors ?? [])
: (itemsInOrder ?? []
Collaborator
There was a problem hiding this comment.
Other than this set state hook, lgtm
drodzewicz
approved these changes
Aug 30, 2024
awalkowiak
approved these changes
Aug 30, 2024
alannadolny
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… number in the table