feature/OBPIH-6516 Infer lot number based on provided bin location#4812
Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom Aug 30, 2024
Conversation
github-actions
bot
added
type: feature
alannadolny
reviewed
Aug 30, 2024
Comment on lines
+26
to
+43
| @BindUsing({ obj, source -> | ||
| // set provided lot number | ||
| if (source['lotNumber']) { | ||
| return source['lotNumber'] | ||
| } | ||
|
|
||
| // otherwise infer inventory item based on provided bin-location | ||
| Location internalLocation = Location.findByNameAndParentLocation(source['binLocation'], obj.origin) | ||
| Product product = Product.findByProductCode(source['product']) | ||
| List<ProductAvailability> items = ProductAvailability.findAllByProductAndBinLocation(product, internalLocation) | ||
|
|
||
| // infer lot-number only if there is a single possible inventory | ||
| if (items.size() == 1) { | ||
| return items.first().lotNumber | ||
| } | ||
|
|
||
| return null | ||
| }) |
Collaborator
There was a problem hiding this comment.
Maybe it's worth moving to a separate method?
Collaborator
Author
There was a problem hiding this comment.
There are many more larger binder methods and we will tackle this issue later in a separate tech-debt ticket
awalkowiak
approved these changes
Aug 30, 2024
awalkowiak
deleted the
feature/OBPIH-6516-inferring-lot-in-packing-list-import-for-full-outbound
branch
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6513
Description:
Added an ability to handle a case where user does not provide a lot number.
If provided binLocation has only one inventoryItem then we infer it since this is the only possible choice a user can make.
📷 Screenshots & Recordings (optional)
📈 Test Plan
Description of test plan (if applicable):
✅ Quality Checks
[OBS-123]for Jira,[#0000]for GitHub, or[OBS-123, OBPIH-123]if there are multiple), or with[N/A]if not applicable