OBPIH-6642 Improve order of items on view Invoice page and Invoice tab on PO#4809
Merged
awalkowiak merged 3 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom Aug 29, 2024
Merged
Conversation
alannadolny
requested review from
awalkowiak,
drodzewicz,
ewaterman and
kchelstowski
github-actions
bot
added
domain: frontend
drodzewicz
approved these changes
Aug 29, 2024
awalkowiak
approved these changes
Aug 29, 2024
awalkowiak
merged commit 9d68ab6
into
feature/OBPIH-6398-partial-invoices-for-prepaid-po
| </thead> | ||
| <tbody> | ||
| <g:each var="invoiceItem" in="${invoiceInstance.invoiceItems.sort { it.dateCreated }}" status="status"> | ||
| <g:each var="invoiceItem" in="${invoiceInstance.getSortedInvoiceItems()}" status="status"> |
Collaborator
There was a problem hiding this comment.
nitpicky, but you've always said you liked the shortened groovy versions, so: you could use the invoiceInstance.sortedInvoiceItems here 😄
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.