Skip to content

OBPIH-6627 Clear uploaded file when trying to redo import and set cached dateShipped value on refresh#4806

Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6627-fixes-after-qa
Aug 29, 2024
Merged

OBPIH-6627 Clear uploaded file when trying to redo import and set cached dateShipped value on refresh#4806
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6627-fixes-after-qa

Conversation

@drodzewicz
Copy link
Collaborator

@drodzewicz drodzewicz commented Aug 28, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: OBPIH-6627

Description:
Issues found after QA testing:

  • remove the uploaded file when clicking "Redo Import" button
  • set cached shipped date value when refreshing the page

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@drodzewicz drodzewicz self-assigned this Aug 28, 2024
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI labels Aug 28, 2024
@awalkowiak awalkowiak merged commit dfb2e00 into feature/outbound-import Aug 29, 2024
@awalkowiak awalkowiak deleted the feature/OBPIH-6627-fixes-after-qa branch August 29, 2024 09:47
Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

awalkowiak pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants