Skip to content

OBPIH-6532 [frontend] Ability to edit invoice item (fixes after QA)#4805

Merged
awalkowiak merged 3 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6532-2
Aug 29, 2024
Merged

OBPIH-6532 [frontend] Ability to edit invoice item (fixes after QA)#4805
awalkowiak merged 3 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6532-2

Conversation

@alannadolny
Copy link
Collaborator

In this PR I fixed:

  • Blocking the "post invoice" button when the invoice contains canceled items
  • Fix error while clicking exit in empty invoices
  • Fix calculating invoice value
  • Fix the UI issue with displaying action menu

@alannadolny alannadolny self-assigned this Aug 28, 2024
@github-actions github-actions bot added domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server flag: config change Hilights a pull request that contains a change to the app config labels Aug 28, 2024
"react-table": "6.8.6",
"react-table-hoc-fixed-columns": "2.3.4",
"react-tabs": "2.3.1",
"react-tiny-popover": "6.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you summarize what this library is giving us over our previous way of handling pop-up messages? Do you think we should be using this approach for all our pop-up messages going forward?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is a replacement for our component called "Action Dots":
image
Previously we created it using Bootstrap, but when this component is placed within the table (basically that's all of our use cases) we had to use a workaround - we didn't let the popup touch the header (because the popup is not visible outside the table) or anything else (the table has fixed row size, so there was always enough space for that). But in the invoices workflow, we can have a table with only one item, and then the popups are not visible. Fixing it with styling is a really hard challenge, and in this case, I was not able to use portals, because the popup is handled by Bootstrap in a different way and there is an error that the portal can't find a defined container. So yeah, from now we should use the component created by me for displaying dropdowns with a menu. For any other popups, I think it depends on the case, but I prefer using this library to be consistent across the whole app.

@awalkowiak awalkowiak merged commit 6aa00b6 into feature/OBPIH-6398-partial-invoices-for-prepaid-po Aug 29, 2024
@awalkowiak awalkowiak deleted the OBPIH-6532-2 branch August 29, 2024 09:52
Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice research about the library

: '';

return (
<React.Fragment key={action.label}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: we can now use the shortened version: <> </>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI flag: config change Hilights a pull request that contains a change to the app config

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants