Skip to content

OBPIH-6621 small improvements to confirm page of full outbound import#4804

Merged
awalkowiak merged 9 commits intofeature/outbound-importfrom
feature/OBPIH-6621-small-improvements-to-confirm-page-of-full-outbound-import
Aug 29, 2024
Merged

OBPIH-6621 small improvements to confirm page of full outbound import#4804
awalkowiak merged 9 commits intofeature/outbound-importfrom
feature/OBPIH-6621-small-improvements-to-confirm-page-of-full-outbound-import

Conversation

@drodzewicz
Copy link
Collaborator

@drodzewicz drodzewicz commented Aug 27, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: OBPIH-6621

Description:
Mostly some styling fixing like

  • better error styling
  • render header when going to the next step (with origin destination date requested)
  • scroll to top of the page when going to the next step

📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.

image


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@drodzewicz drodzewicz self-assigned this Aug 27, 2024
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI domain: backend Changes or discussions relating to the backend server labels Aug 27, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this hook already exists. It's called useResetScrollbar. Can you try to use it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, I had to modify a little this hook so it can accept all kinds of css selector paths and not only clasess

@drodzewicz drodzewicz requested a review from alannadolny August 29, 2024 07:48
@awalkowiak awalkowiak merged commit 6ec53e2 into feature/outbound-import Aug 29, 2024
@awalkowiak awalkowiak deleted the feature/OBPIH-6621-small-improvements-to-confirm-page-of-full-outbound-import branch August 29, 2024 09:46
Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants