OBPIH-6500 [frontend] Modifications to the invoice confirmation page (fix after QA)#4803
Merged
awalkowiak merged 1 commit intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom Aug 26, 2024
Conversation
github-actions
bot
added
the
domain: backend
awalkowiak
reviewed
Aug 26, 2024
| invoiceItems = InvoiceItem.createCriteria().list(max: max.toInteger(), offset: offset.toInteger()) { | ||
| eq("invoice", invoice) | ||
| order("inverse", "asc") | ||
| order("id", "asc") |
Collaborator
There was a problem hiding this comment.
Perhaps sorting by product code here would be better? Before falling back on id?
Collaborator
Author
There was a problem hiding this comment.
No, we can invoice a few products with the same product code and the same issue will be visible.
kchelstowski
approved these changes
Aug 26, 2024
drodzewicz
approved these changes
Aug 26, 2024
awalkowiak
merged commit 074eff0
into
feature/OBPIH-6398-partial-invoices-for-prepaid-po
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket:
Description:
The reopening was caused by duplicating some invoice items / missing some invoice items. Pagination on the frontend fetched items in parts:
0-10 items
10-20 items
20-30 items
....
Each data fetching was in a different order, so each request can duplicate items.