OBPIH-6532 [frontend] Ability to edit invoice item#4798
Merged
awalkowiak merged 8 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom Aug 26, 2024
Merged
OBPIH-6532 [frontend] Ability to edit invoice item#4798awalkowiak merged 8 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
awalkowiak merged 8 commits intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
Conversation
alannadolny
added
status: work in progress
github-actions
bot
added
domain: frontend
alannadolny
added
the
warn: do not merge
awalkowiak
reviewed
Aug 22, 2024
| return invoice?.isPrepaymentInvoice | ||
| } | ||
|
|
||
| Integer getQuantityAvailableToInvoice() { |
Collaborator
There was a problem hiding this comment.
Could it be just:
return shipmentItem ? (shipmentItem.quantityToInvoiceInStandardUom / quantityPerUom) + quantity : null // or 0
Collaborator
There was a problem hiding this comment.
I think there might be some comments needed in this hook, especially for revertQuantityToEdited
alannadolny
force-pushed
the
OBPIH-6532
branch
from
a2084fc to
5d1559e
Compare
alannadolny
removed
status: work in progress
drodzewicz
approved these changes
Aug 26, 2024
github-actions
bot
added
the
domain: l10n
…nding and submitted
alannadolny
force-pushed
the
OBPIH-6532
branch
from
6038a6d to
d3db523
Compare
awalkowiak
merged commit c9e99ff
into
feature/OBPIH-6398-partial-invoices-for-prepaid-po
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: https://pihemr.atlassian.net/browse/OBPIH-6532
Description:
This PR is still in progress but ready for initial review. Before merging this one, merge the PR with the remove action.