Skip to content

OBPIH-6499 Do not create inverse if no quantity to inverse#4797

Merged
awalkowiak merged 1 commit intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6499
Aug 21, 2024
Merged

OBPIH-6499 Do not create inverse if no quantity to inverse#4797
awalkowiak merged 1 commit intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6499

Conversation

@awalkowiak
Copy link
Collaborator

@awalkowiak awalkowiak commented Aug 21, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-6499

Description:
Fix for the issue found during QA (If there will be created dangling item due to transactional it will be saved as an orphan empty item and there will be attempt to save it, and an error is thrown. There was a need to change ordering to avoid this issue - first check if there is quantity to inverse and then create inverse item)


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@awalkowiak awalkowiak requested a review from alannadolny August 21, 2024 10:31
@github-actions github-actions bot added the domain: backend Changes or discussions relating to the backend server label Aug 21, 2024
@awalkowiak awalkowiak merged commit 77e4397 into feature/OBPIH-6398-partial-invoices-for-prepaid-po Aug 21, 2024
@awalkowiak awalkowiak deleted the OBPIH-6499 branch August 21, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants