Skip to content

[OBPIH-6624] Trigger ShipmentStatusTransitionEvent event when sending a shipment on full outbound import#4794

Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6624-expiry-date-in-full-outbound-import
Aug 21, 2024
Merged

[OBPIH-6624] Trigger ShipmentStatusTransitionEvent event when sending a shipment on full outbound import#4794
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6624-expiry-date-in-full-outbound-import

Conversation

@drodzewicz
Copy link
Collaborator

@drodzewicz drodzewicz commented Aug 20, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: OBPIH-6625

Description:
In a regular outbound workflow when sending a shipment we have this exact code that triggers an event which handles sending appropriate notification to the user based on the provided shipmentStatus, the only problem was that the new implementation on the full outbound workflow was missing this event publish.


📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@drodzewicz drodzewicz requested a review from awalkowiak August 20, 2024 15:27
@drodzewicz drodzewicz self-assigned this Aug 20, 2024
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: backend Changes or discussions relating to the backend server labels Aug 20, 2024
@awalkowiak awalkowiak merged commit fb8a912 into feature/outbound-import Aug 21, 2024
@awalkowiak awalkowiak deleted the feature/OBPIH-6624-expiry-date-in-full-outbound-import branch August 21, 2024 07:32
awalkowiak pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: backend Changes or discussions relating to the backend server type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants