Skip to content

[OBPIH-6624] Default value on DateCell Component#4793

Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6624-expiry-date-in-full-outbound-import
Aug 20, 2024
Merged

[OBPIH-6624] Default value on DateCell Component#4793
awalkowiak merged 1 commit intofeature/outbound-importfrom
feature/OBPIH-6624-expiry-date-in-full-outbound-import

Conversation

@drodzewicz
Copy link
Collaborator

@drodzewicz drodzewicz commented Aug 20, 2024

✨ Description of Change

A concise summary of what is being changed. Please provide enough context for reviewers to be able to understand the change and why it is necessary. If the issue/ticket already provides enough information, you can put "See ticket" as the description.

Link to GitHub issue or Jira ticket: OBPIH-6624

Description:
This is a small UI change where we want to display an empty cell instead of a default value which is a "-". I noticed that on DateCell components we do not have a customizable prop for this value so I implemented it and made appropriate changes to the Full outbound workflow table expiration date column


📷 Screenshots & Recordings (optional)

If this PR contains a UI change, consider adding one or more screenshots here or link to a screen recording to help reviewers visualize the change. Otherwise, you can remove this section.
image


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

- Add ability to configure defaultValue for custom DateCell component
- Set an empty string for expiration date column on OutboundImport Table
@drodzewicz drodzewicz requested a review from awalkowiak August 20, 2024 12:14
@drodzewicz drodzewicz self-assigned this Aug 20, 2024
@github-actions github-actions bot added type: feature A new piece of functionality for the app domain: frontend Changes or discussions relating to the frontend UI labels Aug 20, 2024
@drodzewicz drodzewicz changed the title OBPIH-6624 Default value on DateCell Component [OBPIH-6624] Default value on DateCell Component Aug 20, 2024
@awalkowiak awalkowiak merged commit a9c1333 into feature/outbound-import Aug 20, 2024
@awalkowiak awalkowiak deleted the feature/OBPIH-6624-expiry-date-in-full-outbound-import branch August 20, 2024 12:39
Copy link
Collaborator

@kchelstowski kchelstowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: frontend Changes or discussions relating to the frontend UI type: feature A new piece of functionality for the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants