[OBPIH-6624] Default value on DateCell Component#4793
Merged
awalkowiak merged 1 commit intofeature/outbound-importfrom Aug 20, 2024
Merged
Conversation
- Add ability to configure defaultValue for custom DateCell component - Set an empty string for expiration date column on OutboundImport Table
awalkowiak
approved these changes
Aug 20, 2024
awalkowiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description of Change
Link to GitHub issue or Jira ticket: OBPIH-6624
Description:
This is a small UI change where we want to display an empty cell instead of a default value which is a
"-". I noticed that onDateCellcomponents we do not have a customizable prop for this value so I implemented it and made appropriate changes to the Full outbound workflow table expiration date column📷 Screenshots & Recordings (optional)
📈 Test Plan
Description of test plan (if applicable):
✅ Quality Checks
[OBS-123]for Jira,[#0000]for GitHub, or[OBS-123, OBPIH-123]if there are multiple), or with[N/A]if not applicable