Skip to content

OBPIH-6610 Exclude inverse items from order summary view#4785

Merged
awalkowiak merged 1 commit intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6610
Aug 19, 2024
Merged

OBPIH-6610 Exclude inverse items from order summary view#4785
awalkowiak merged 1 commit intofeature/OBPIH-6398-partial-invoices-for-prepaid-pofrom
OBPIH-6610

Conversation

@awalkowiak
Copy link
Collaborator

@awalkowiak awalkowiak commented Aug 13, 2024

✨ Description of Change

Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-6610

Description:
See tickets description (File to review: order-summary-helper-views.sql, rest is the calculate inverse items that's in separate PR)


📈 Test Plan

We require that all code changes come paired with a method of testing them. Please select which of the following testing approaches you've included with this change:

  • Frontend automation tests (unit)
  • Backend automation tests (unit, API, smoke)
  • End-to-end tests (Playwright)
  • Manual tests (please describe below)
  • Not Applicable

Description of test plan (if applicable):
Order summary (derived status) calculation for payment statuses (invoices) needs to be checked.


✅ Quality Checks

Please confirm and check each of the following to ensure that your change conforms to the coding standards of the project:

  • The pull request title is prefixed with the issue/ticket number (Ex: [OBS-123] for Jira, [#0000] for GitHub, or [OBS-123, OBPIH-123] if there are multiple), or with [N/A] if not applicable
  • The pull request description has enough information for someone without context to be able to understand the change and why it is needed
  • The change has tests that prove the issue is fixed / the feature works as intended

@github-actions github-actions bot added the flag: schema change Hilights a pull request that contains a change to the database schema label Aug 13, 2024
@awalkowiak awalkowiak changed the base branch from OBPIH-6499 to feature/OBPIH-6398-partial-invoices-for-prepaid-po August 13, 2024 15:21
@awalkowiak awalkowiak added warn: do not merge Marks a pull request that is not yet ready to be merged status: ready for review Flags that a pull request is ready to be reviewed labels Aug 13, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: this file is the only real change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry for the confusion, I forgot that all the other commits are now visible after the base branch change. I should make the description clearer.

@awalkowiak awalkowiak removed warn: do not merge Marks a pull request that is not yet ready to be merged status: ready for review Flags that a pull request is ready to be reviewed labels Aug 19, 2024
@awalkowiak awalkowiak merged commit 0c07c06 into feature/OBPIH-6398-partial-invoices-for-prepaid-po Aug 19, 2024
@awalkowiak awalkowiak deleted the OBPIH-6610 branch August 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flag: schema change Hilights a pull request that contains a change to the database schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants