OBPIH-6329 Full outbound import - Details step (Fixes after QA)#4663
Merged
awalkowiak merged 3 commits intodevelopfrom Jun 12, 2024
Merged
OBPIH-6329 Full outbound import - Details step (Fixes after QA)#4663awalkowiak merged 3 commits intodevelopfrom
awalkowiak merged 3 commits intodevelopfrom
Conversation
Collaborator
kchelstowski
commented
Jun 12, 2024
kchelstowski
commented
- origin is filled by default with the current location
- date shipped validation (can't be date from the past)
- expected delivery date validation (can't be before the date shipped)
awalkowiak
requested changes
Jun 12, 2024
src/js/utils/form-utils.jsx
Outdated
| * @param laterDate | ||
| * @param earlierDate | ||
| */ | ||
| export const validateOneAfterAnotherDate = (laterDate, earlierDate) => { |
Collaborator
There was a problem hiding this comment.
validateOneAfterAnotherDate - "Method to check if first date is later than the second date", but you check isSameOrAfter.
kchelstowski
force-pushed
the
OBPIH-6329-fix
branch
from
9baacd0 to
bafd96f
Compare
awalkowiak
approved these changes
Jun 12, 2024
kchelstowski
force-pushed
the
OBPIH-6329-fix
branch
from
bafd96f to
4adb592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.