OBPIH-6328 Dashboard indicator for items with backdated shipments (disable string truncation)#4649
Merged
awalkowiak merged 4 commits intodevelopfrom Jun 5, 2024
Merged
OBPIH-6328 Dashboard indicator for items with backdated shipments (disable string truncation)#4649awalkowiak merged 4 commits intodevelopfrom
awalkowiak merged 4 commits intodevelopfrom
Conversation
kchelstowski
approved these changes
Jun 4, 2024
alannadolny
added
the
warn: do not merge
alannadolny
removed
the
warn: do not merge
awalkowiak
requested changes
Jun 4, 2024
| ColorNumber twoDelayedShipments = new ColorNumber(value: amountOfItemsWithBackdatedShipments[Constants.TWO], subtitle: '2 shipments', order: 2) | ||
| ColorNumber threeDelayedShipments = new ColorNumber(value: amountOfItemsWithBackdatedShipments[Constants.THREE], subtitle: '3 shipments', order: 3) | ||
| ColorNumber fourOrMoreDelayedShipments = new ColorNumber(value: amountOfItemsWithBackdatedShipments[Constants.FOUR_OR_MORE], subtitle: '4 or more shipments', order: 4) | ||
| ColorNumber fourOrMoreDelayedShipments = new ColorNumber(value: amountOfItemsWithBackdatedShipments[Constants.FOUR_OR_MORE], subtitle: '4 or more', order: 4) |
Collaborator
There was a problem hiding this comment.
I think it is worth translating these labels now.
| DATE_FORMAT(stock_count.last_stock_count, "%d-%M-%Y") FROM ( | ||
| ( | ||
| SELECT t.id as transaction_id, s.shipment_number FROM shipment s | ||
| DATE_FORMAT(stock_count.last_stock_count, "%d-%b-%Y"), |
Collaborator
There was a problem hiding this comment.
I am assuming that we are leaving this as is for now, but I think this will have to be covered as a part of localized date tickets in the near future.
awalkowiak
approved these changes
Jun 5, 2024
drodzewicz
pushed a commit
that referenced
this pull request
Jun 11, 2024
…sable string truncation) (#4649) * OBPIH-6328 Add disabling truncation * OBPIH-6328 change colouring, fix labels, add hyperlinks to products and shipments * OBPIH-6328 Fix columns length * OBPIH-6328 Add labels for subtitles and headers
drodzewicz
pushed a commit
that referenced
this pull request
Jun 11, 2024
…sable string truncation) (#4649) * OBPIH-6328 Add disabling truncation * OBPIH-6328 change colouring, fix labels, add hyperlinks to products and shipments * OBPIH-6328 Fix columns length * OBPIH-6328 Add labels for subtitles and headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things added after Manon's request: