OBPIH-6332 Dashboard indicator for number of backdated shipments (Fix overriding config value)#4629
Merged
awalkowiak merged 2 commits intodevelopfrom May 21, 2024
Merged
OBPIH-6332 Dashboard indicator for number of backdated shipments (Fix overriding config value)#4629awalkowiak merged 2 commits intodevelopfrom
awalkowiak merged 2 commits intodevelopfrom
Conversation
awalkowiak
requested changes
May 20, 2024
|
|
||
| Map getBackdatedShipmentsChart(String locationId, Integer monthsLimit, StockMovementDirection direction) { | ||
| Map<String, Integer> data = Constants.backdataAxes | ||
| Map<String, Integer> data = Constants.backdataAxes.clone() |
Collaborator
There was a problem hiding this comment.
I missed that one before. I think Constants is not the best place for things that can be changed. I looked into the previous request and it was "I would suggest moving those "2 days" etc. to static constants in Constants.groovy, as this might be reused in the future" - I think it meant only the keys, not entire map (correct me if I am wrong here @kchelstowski).
Either way, I think this map should not be kept as is in the consts.
Collaborator
There was a problem hiding this comment.
@awalkowiak yes, I meant the keys. I'm sorry @alannadolny I haven't noticed it in the previous PR.
awalkowiak
approved these changes
May 21, 2024
awalkowiak
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.