OBPIH-6368 Fix statuses mapping on outbound list page while filtering after state machine refactor + remove unused filters#4624
Conversation
… after state machine refactor + remove unused filters
kchelstowski
requested review from
alannadolny,
awalkowiak,
drodzewicz,
ewaterman and
jmiranda
alannadolny
changed the title
| WHEN o.status IS NULL THEN 'CREATED' | ||
| WHEN o.status = 'PENDING' THEN 'CREATED' | ||
| WHEN o.status = 'PLACED' THEN 'CHECKING' | ||
| WHEN o.status = 'APPROVED' THEN 'PICKING' | ||
| WHEN o.status = 'CANCELED' THEN 'CANCELED' | ||
| # These probably won't be used but we want to cover them just in case | ||
| WHEN o.status = 'PARTIALLY_RECEIVED' THEN 'DISPATCHED' | ||
| WHEN o.status = 'RECEIVED' THEN 'DISPATCHED' | ||
| WHEN o.status = 'COMPLETED' THEN 'DISPATCHED' | ||
| WHEN o.status = 'PARTIALLY_RECEIVED' THEN 'ISSUED' | ||
| WHEN o.status = 'RECEIVED' THEN 'ISSUED' | ||
| WHEN o.status = 'COMPLETED' THEN 'ISSUED' |
There was a problem hiding this comment.
I remember that we followed another idea while we were working on state machine refactoring, do we feel comfortable with this right now? 🤔
|
wasn't this the whole point that PR ##4586 was closed? |
|
@drodzewicz @alannadolny as we discussed this internally on Slack, this was the easiest and cleanest way to fix this issue with filtering. I believe this was even mentioned on the planning call as a required solution. I know we decided at the start of this status-related work to avoid changing SQL vies, but I feel like this is the right approach here. |
awalkowiak
left a comment
awalkowiak
left a comment
There was a problem hiding this comment.
@kchelstowski please add comments in this view about what is a status_code, what is a status, what it is used for, and why we see still DISPATCHED for status_code for cases we have ISSUED for status, plus overall why we are changing this one here, where this change came from, etc. Be as descriptive as possible (you could also add a link to the ticket)
|
@awalkowiak I've added comments + I've deprecated the |
4 participants
… after state machine refactor + remove unused filters